fix: do not remove documentation and execution listeners when template is removed

bpmn-io / bpmn-js-element-templates

The element template extension for bpmn-js

MIT License

5 stars 3 forks source link

fix: do not remove documentation and execution listeners when template is removed #120

Open jarekdanielak opened 1 month ago

jarekdanielak commented 1 month ago

Closes #114

Proposed Changes

When removing template from element, documentation and execution listeners (and potentially more non-template properties in the future) are kept.

https://github.com/user-attachments/assets/187c7e81-aac5-4c81-b9c1-6a20e605f512

Checklist

To ensure you provided everything we need to look at your PR:

[X] Brief textual description of the changes present
[X] Visual demo attached
[ ] Steps to try out present, i.e. using the @bpmn-io/sr tool
[X] Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

jarekdanielak commented 2 weeks ago

@nikku I moved the 2 command handlers shared between C7 and C8 to a common folder.

Is there any reason we shouldn't support C7?

nikku commented 2 weeks ago

Is there any reason we shouldn't support C7?

Camunda 7 works slightly differently, and we don't aim to touch (and potentially break) existing Camunda 7 behaviors.

nikku commented 2 weeks ago

Will have another look onto this PR shortly.

nikku commented 2 weeks ago

I'll give this PR another look and sketch the relevant changes :)

barmac commented 3 days ago

I like the idea to move shared things outside of element-templates / cloud-element-templates.

However the handler now still mixes both implementations, which I'd like to avoid. Thinking in terms of modularization I'd like to remove the element-templates folder, some day in the future, and all element template related code is gone. Same thing the other way around.

I'll move the PR to draft until the change is implemented or we reconsider.