search

bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
293 stars 196 forks source link

Properties Panel Header Displays Element Template Icon Found in Template Instead of XML #1011

Closed zxuanhong closed 8 months ago

zxuanhong commented 9 months ago

Is your feature request related to a problem? Please describe.

  1. The properties at the top of the icon with ElementTemplateIconRenderer get icon logically consistent. Get it directly from the element or read it from the built-in icon.
  2. If the logic is consistent, you can customize the icon of an element
  3. Key code ElementTemplateIconRenderer access icon image
  4. And now once the template is lost, it will also cause the element icon to render properly, but the properties header icon will not render properly.For example image
nikku commented 9 months ago

@zxuanhong We read it from the rendered XML because we want the icon to be present also in the case of missing element template.

Do I understand you correctly that your feature request is to use the same mechanism to read the icon in the properties panel? There we currently read the icon from the connected element template.

zxuanhong commented 9 months ago

@nikku yes. the properties panel should also be read from xml. I submitted a pr, hoping it would be helpful #1012