search

bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
286 stars 196 forks source link

Refactor PanelHeaderProvider to accept a translate function #1041

Closed ulli-hoeness closed 2 months ago

ulli-hoeness commented 3 months ago

Closes #813

PanelHeaderProvider has been refactored into a higher-order function that requires a translate function as its input. This change enables dynamic translation support within the provider, allowing for localization of type labels in the panel header. The function now returns the configured PanelHeaderProvider object, ready for use with the supplied translate function.

test/spec/PanelHeaderProvider.spec.js was changed to accommodate the new refactoring.

barmac commented 2 months ago

I just noticed that an identical contribution was provided via https://github.com/bpmn-io/bpmn-js-properties-panel/pull/1045. I will add you as a code co-author as it was all squashed in one commit.

barmac commented 2 months ago

You're added via https://github.com/bpmn-io/bpmn-js-properties-panel/commit/03895640267fd88ef853f0f98bab7660df8d1ba9. Thanks for your contribution, and sorry for a delay in feedback on the PR.

ulli-hoeness commented 2 months ago

You're added via 0389564. Thanks for your contribution, and sorry for a delay in feedback on the PR.

No worries and thank you :)