search

bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
286 stars 196 forks source link

feat (properties/IdProps) : add hint for the process ID field in the Camunda 7 properties Panel #1043

Closed prakashpalanisamy closed 2 months ago

prakashpalanisamy commented 2 months ago

Closes #1038

Note Not Appearing for the ID field in the Default Behaviour of the Property Panel: bpmn-io-properties-generic

Note Appearing for the ID field in the Camunda 7.x modeler - Process level: image

Note Not Appearing for the ID field in the Camunda 7.x modeler - Activity level: image

Note Not Appearing for the ID field in the Camunda 8.x modeler - Process level: image

barmac commented 2 months ago

To make this solution complete, we should also add a hint in the participant's process ID entry:

image

nikku commented 2 months ago

@prakashpalanisamy Do you want to follow-up on the review comments? What I believe is missing is to consider https://github.com/bpmn-io/bpmn-js-properties-panel/pull/1043#issuecomment-2072095082. We could of course also merge the solution as is.

prakashpalanisamy commented 2 months ago

@barmac , @nikku I'm on vacation this week. I'll push the updates on Monday next week.

prakashpalanisamy commented 2 months ago

@prakashpalanisamy Do you want to follow-up on the review comments? What I believe is missing is to consider #1043 (comment). We could of course also merge the solution as is.

@nikku : I have addressed the Participant Process ID issue along with the latest changes. Please take a look. thanks!

prakashpalanisamy commented 2 months ago

Camunda 7 Process ID hint displays image

Camunda 7 Participant Process ID hint displays image

Camunda 7 hint NOT displayed for Collaboration ID image

Camunda 8 Process ID hint NOT displayed image

Camunda 8 Participant Process ID hint NOT displayed image

Camunda 8 hint for Collaboration ID NOT displayed image

BPMN IO Properties Panel Default Behaviour - hint does NOT appear for Process ID image

BPMN IO Properties Panel Default Behaviour - hint does NOT appear for Participant Process ID image

BPMN IO Properties Panel Default Behaviour - hint does NOT appear for Collaboration ID image

barmac commented 2 months ago

Thanks! I will have a look at this today.

barmac commented 2 months ago

I merged this via https://github.com/bpmn-io/bpmn-js-properties-panel/commit/23c39745f2c86efe148c942b4190ea0aa2c7eb1b. Thank you for your contribution!

prakashpalanisamy commented 2 months ago

I merged this via 23c3974. Thank you for your contribution!

Thank you @barmac & @nikku for your time