bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
293 stars 196 forks source link

Panel headers and Zeebe's tab labels translations are missing #1044

Closed Rastuharem closed 5 months ago

Rastuharem commented 5 months ago

Describe the Bug

In current state, exists translation functionality, which works only on some of the tab's labels (#1014). In header's case, no header can be translated.

Steps to Reproduce

1.) Create custom translate function, which translates any word into some symbol:

export default {
  translate: [
    'value',
    function customTranslate(template, replacements) {
      return '✔';
    },
  ],
};

2.) Apply it to bpmn modeler

import {
  BpmnPropertiesPanelModule,
  BpmnPropertiesProviderModule,
  ZeebePropertiesProviderModule,
} from 'bpmn-js-properties-panel';

import testTranslation from '@/some/path/toFile';
...
const options = {
  propertiesPanel: { parent: '#js-properties-panel' },
  additionalModules: [
    BpmnPropertiesPanelModule,
    BpmnPropertiesProviderModule,
    ZeebePropertiesProviderModule,

    testTranslation,
  ],
};

const bpmnViewer = new BpmnModeler(options);

3.) Check result:

image

We can see that headers and some tabs are not translated. (It seems that all Zeebe's tabs are not translated)

Expected Behavior

All headers and tab's labels should be translated

Environment

Rastuharem commented 5 months ago

I would like to try fix this issue

barmac commented 5 months ago

Thanks for raising this. We are happy to accept your contribution fixing this.