search

bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
290 stars 196 forks source link

Remove element templates #937

Closed marstamm closed 1 year ago

marstamm commented 1 year ago

They now live in https://github.com/bpmn-io/bpmn-js-element-templates

related to https://github.com/camunda/camunda-modeler/issues/3357

smbea commented 1 year ago

So we still consider element templates for rendering purposes (such as https://github.com/bpmn-io/bpmn-js-properties-panel/blob/remove-element-templates/src/render/PanelHeaderProvider.js#L71) but logic is completely removed, right?

marstamm commented 1 year ago

Yes, some aspects of element templates can not be easily isolated from the module. Goal for this PR is to remove the main element-template logic from the properties-panel. Individual Providers might still react and use the element template service when it is present

smbea commented 1 year ago

Makes sense, just wanted to clarify!