bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
286 stars 196 forks source link

feat(feel-popup): provide container for feel popup editors #970

Closed pinussilvestrus closed 10 months ago

pinussilvestrus commented 10 months ago

Use via

propertiesPanel: {
  feelPopupContainer: ...
}

Follow up of https://github.com/bpmn-io/properties-panel/pull/280

pinussilvestrus commented 10 months ago

@bpmn-io/modeling-dev will we need to adapt this in camunda-bpmn-js as well to make the feature work?

nikku commented 10 months ago

Please add a note to the changelog.

nikku commented 10 months ago

will we need to adapt this in camunda-bpmn-js as well to make the feature work?

camunda-bpmn-js only passes through properties, so I'd say no.

pinussilvestrus commented 10 months ago

Please add a note to the changelog.

Thanks for mentioning 👍 done via https://github.com/bpmn-io/bpmn-js-properties-panel/pull/970/commits/9dc593c03f82ecefbc1f6f97651b19fca32d4f76