search

bpmn-io / bpmn-js-properties-panel

A properties panel for bpmn-js.
MIT License
286 stars 196 forks source link

Prepare v5.6.0 #991

Closed nikku closed 9 months ago

nikku commented 9 months ago

Let's cut this release to integrate the changes downstream!

smbea commented 9 months ago

Let's just resolve conflicts and we can go ahead

nikku commented 9 months ago

Doing it!

nikku commented 9 months ago

Updated.

barmac commented 9 months ago

Shall we hold this till https://github.com/bpmn-io/bpmn-js-element-templates/pull/25#issuecomment-1768763108?

barmac commented 9 months ago

🔴 If we update camunda-bpmn-js-behaviors, the zeebe:subscription will be broken due to the same reason as in bpmn-js-element-templates. We should add the property in one go instead of multi-command shenanigans: https://github.com/bpmn-io/bpmn-js-properties-panel/blob/main/src/provider/zeebe/properties/MessageProps.js#L138

barmac commented 9 months ago

Done via https://github.com/bpmn-io/bpmn-js-properties-panel/pull/991/commits/a06e55c851984af5c28872fb323d7dc775dea6c0

This shows how multicommand command breaks the command atomicity :/