bpmn-io / bpmn-js-token-simulation

A BPMN 2.0 specification compliant token simulator.
https://bpmn-io.github.io/bpmn-js-token-simulation/modeler.html?e=1&pp=1
MIT License
255 stars 74 forks source link

Expose public API + make available safely #113

Open nikku opened 2 years ago

nikku commented 2 years ago

Is your feature request related to a problem? Please describe

Token simulation is a huge extension. Because of that it has a certain set of issues:

Describe the solution you'd like

Describe alternatives you've considered

Keep what exists, even if it is a little messy.

Additional context

Using didi __exports__ is properly working since since https://github.com/nikku/didi/pull/13; we could consider to integrate it / use it with bpmn-js-token-simulation.

nikku commented 2 months ago

We fell for missing isolation in https://github.com/bpmn-io/bpmn-js-token-simulation/issues/139.

barmac commented 2 months ago

Given that there are more issues above #139 (cf. https://github.com/bpmn-io/bpmn-js-token-simulation/issues/139#issuecomment-2306607426), I'd like to raise the priority of this. Note that the bugs will affect Web Modeler users (design mode).

barmac commented 2 months ago

So at least the "service footprint" should be fixed.

nikku commented 2 months ago

We quickly discussed with @barmac different solutions and settled down on two options:

Both approaches would be a major breaking change. I'll investigate further.

barmac commented 2 months ago

Assigning @nikku to investigate in a time-boxed manner.