search

bpmn-io / bpmn-js-token-simulation

A BPMN 2.0 specification compliant token simulator.
https://bpmn-io.github.io/bpmn-js-token-simulation/modeler.html?e=1&pp=1
MIT License
249 stars 71 forks source link

Elements Can Be Selected When Token Simulation Active #161

Closed philippfromme closed 6 months ago

philippfromme commented 7 months ago

Describe the Bug

When the token simulation is active elements can still be selected. When disabling the token simulation the context pad remains hidden even though an element is selected.

brave_gNAHOOY8pG

Steps to Reproduce

  1. Activate token simulation
  2. Click on an element to select it
  3. Disable token simulation
  4. Outline is visible but context pad is hidden

Expected Behavior

Either disable selection completely or fully support it (including outline).

Environment

nikku commented 7 months ago

I think there is absolutely a use-case for this one, especially as token-simulation accounts for certain details (such as link names and messages).

Could you assess this bug report against a fully-fledged simulation setup, i.e. https://bpmn-io.github.io/bpmn-js-token-simulation/modeler.html?pp=1&e=1?

philippfromme commented 7 months ago

I think there is absolutely a use-case for this one, especially as token-simulation accounts for certain details (such as link names and messages).

Could you assess this bug report against a fully-fledged simulation setup, i.e. https://bpmn-io.github.io/bpmn-js-token-simulation/modeler.html?pp=1&e=1?

Can you elaborate? What should happen if I click an element when token simulation is active? If we want to make selection available during token simulation we have to show the outline as well.

nikku commented 7 months ago

If I click on an element it gets focused, and I can check details (i.e. message assignments) on the element, i.e. during a BPMN training session.

capture RTq7VE_optimized

Selection is not the primary use case, hence there is no selection outline shown. Still, as long as we show the properties panel, we'd need some way to select elements, hence I'm fine with the existing tradeoff (not showing the selection UI, but updating the properties panel with the existing selection).

Given our new (and less intrusive) selection we could, of course, also play with restoring the selection outline. We'd want to evaluate if it adds too much distraction.

philippfromme commented 7 months ago

Okay, understood. Selection is a valid use case. I still think if we want to support it we should bring back the outline, maybe in a less prominent form. Otherwise, it looks broken. The context pad not showing on deactivating the token simulation is still a bug that needs fixing.

nikku commented 6 months ago

Closing this issue. As discussed it is debatable if it is a bug or a feature.