fix: undefined eventDefinitions on some elements

[dgkm]

This MR is fixing the businessObject.eventDefinitions undefined exception received on some elements.

Fix for events failing at bo.eventDefinitions.length as undefined on some elements.

[CLAassistant]

All committers have signed the CLA.

[nikku]

@dgkm Please provide me with a diagram that reproduces the issue in the first place. I'd consider (if possible) to add a test case, too.

[dgkm]

I couldn't reproduce this on the online demo or the example application.

In my local environment I'm facing issues on your example bpmn itself. I have BPMN modeler integrated with a react app and I'm facing the issue.

Please refer to the debug screen showing the bo.eventDefinitions as undefined

This is the example flow I'm referring to where I was able to reproduce this on my local environment:

If you need any further information then please let me know.

[philippfromme]

I think it's generally a good idea to guard against eventDefinitions not existing. This issue can also be fixed by using bo.get('eventDefinitions') which will always return an array since eventDefinitions is defined as isMany = true. In any case we'd want a test case verifying the fix.

[dgkm]

bo.get('eventDefinitions')

@philippfromme , perfect, it is actually working when I watch bo.get('eventDefinitions') in debug mode. Accordingly I have modified the fix to use bo.get('eventDefinitions').length in place of bo.eventDefinitions.length.

I hope you can continue with this.

[nikku]

Thanks for the improvement @dgkm :slightly_smiling_face:

[nikku]

Released with v0.34.1.