search

bpmn-io / bpmn-js-token-simulation

A BPMN 2.0 specification compliant token simulator.
https://bpmn-io.github.io/bpmn-js-token-simulation/modeler.html?e=1&pp=1
MIT License
254 stars 72 forks source link

Cannot navigate into collapsed sub-process #188

Open thomas-ferchau opened 2 months ago

thomas-ferchau commented 2 months ago

Describe the Bug

When activating the token simulation in Camunda Modeler for a BPMN process that contains a collapsed sub-process, I cannot navigate into the sub-process.

Problem: The blue arrow icon next to the collapsed sub-process task is missing: collapsed-subprocess-missing-blue-arrow.png

Therefore, I cannot see the token going through the sub-process. And when a token pauses in the sub-process (at a pause point, for example), I cannot make it continue - so the simulation is stalled at that point.

The problem of the missing arrow icon occurs with the latest token simulation plugin that contains version 0.34.4. It works with plugin v0.20.0 that contains version 0.33.0.

Steps to Reproduce

  1. Download and install Camunda Open Source Desktop Modeler from (I used Windows 64-bit version 5.26.0) https://camunda.com/de/download/modeler/
  2. Clone the Camunda Modeler Token Simulation Plug-in repository into the sub-directory resources/plugins of the Camunda Modeler installation directory https://github.com/camunda/camunda-modeler-token-simulation-plugin
  3. Start Camunda Modeler and open the attached collapsed-subprocess.bpmn (attached in bpmn-files.zip).
  4. Navigate into the collapsed sub-process by clicking the blue arrow next to the collapsed sub-process task. Enable the token simulation. Enable a pause point in the task inside the sub-process. Navigate back to the main process.
  5. Start the token simulation in the main process. The simulation pauses, showing two tokens at the top.
  6. Problem: There is no blue arrow next to the collapsed sub-process task (see screenshot).
  7. As a workaround, toggle the problems view and click the warning listed for "task in collapsed sub-process". This navigates to the sub-process. You can now click the play button of the task to continue the simulation.

For comparison, I have also attached expanded-subprocess.bpmn (no problem there).

To try a working version, stop the modeler, delete the sub-directory camunda-modeler-token-simulation-plugin, and instead extract the zip file of the plugin v0.20.0 into resources/plugins. Then repeat the steps above - the blue arrow is displayed in this version https://github.com/camunda/camunda-modeler-token-simulation-plugin/releases/tag/v0.20.0

Expected Behavior

The blue arrow for navigating into the collapsed sub-process should be visible.

Note: The screen recording in https://github.com/bpmn-io/bpmn-js-token-simulation/issues/114 shows the blue arrow while the simulation is active (must have been recorded with an older version).

Environment

nikku commented 2 months ago

@philippfromme Not being able to navigate inside is probably a side-effect of https://github.com/bpmn-io/bpmn-js-token-simulation/blob/main/CHANGELOG.md#0331. :upside_down_face:

nikku commented 2 months ago

Thanks @thomas-ferchau for the report. This relates to https://github.com/bpmn-io/bpmn-js-token-simulation/issues/114, a general improvement issue we have open.