search

bpmn-io / bpmn-js

A BPMN 2.0 rendering toolkit and web modeler.
https://bpmn.io/toolkit/bpmn-js/
Other
8.67k stars 1.33k forks source link

Calling the search string does not work with the RU keyboard layout #1888

Open emargin opened 1 year ago

emargin commented 1 year ago

Describe the Bug

I want to use BPMN script search using the cntrl+f hotkeys, this behavior works correctly only when my computer's layout is set to EN(English), but if the layout is ru(Russian), the key combination does not work, and works just cntrl+shift+f

Steps to Reproduce

1.open bpmn script

  1. select NON EN(ENGLISH) keyboard layout (in my case RU(RUSSIAN))
  2. press the key combination cntrl + f

Expected Behavior

a search string is expected to appear inside the bpmn script

Environment

barmac commented 1 year ago

Thanks for reporting. I cannot reproduce it on Mac/Chrome. Please update info about your environment.

nikku commented 1 year ago

Potentially related to https://github.com/camunda/camunda-modeler/issues/2724. With the Russian keyboard layout enabled we'd need to assert physical keys, which we don't do, at the moment I think?

The key is to select a keyboard layout with non latin keys (i.e. f is mapped to a different logical character).

nikku commented 1 year ago

Moving to backlog assuming https://github.com/bpmn-io/bpmn-js/issues/1888#issuecomment-1511619150 as no further input is provided.