search

bpmn-io / bpmn-js

A BPMN 2.0 rendering toolkit and web modeler.
https://bpmn.io/toolkit/bpmn-js/
Other
8.35k stars 1.29k forks source link

feat: render markers as part of djs-visual #2173

Closed marstamm closed 1 month ago

marstamm commented 1 month ago

This allows styling with canvas.addMarker and css, as described in our examples. Requires https://github.com/bpmn-io/diagram-js/pull/906

related to https://github.com/camunda/camunda-modeler/issues/4307

marstamm commented 1 month ago

I manually tested against complex.bpm (https://demo.bpmn.io/s/application-processing) and there was no noticeable performance decrease

nikku commented 1 month ago

@marstamm Please verify the diagram-js update does not break dmn-js, and if it does bump diagram-js there, too.

Please also cut a release of this change (in bpmn-js), so users can have a clean (and compatible) install again.

marstamm commented 1 month ago

I verified that the diagram-js update does not break dmn-js. I'll release bpmn-js soon, but old bpmn-js versions are also compatible with the new diagram-js version.

Only reason some tests failed before the update was a CSS selector checking for a certain number of paths in a visual, which broke the assertion when we added the marker with an additional path. The behavior was still working as intended

marstamm commented 1 month ago

I want to get https://github.com/bpmn-io/bpmn-js/issues/1676#issuecomment-2135203329 into the release

marstamm commented 1 month ago

Released as v17.8.0