bpmn-io / bpmn-js

A BPMN 2.0 rendering toolkit and web modeler.
https://bpmn.io/toolkit/bpmn-js/
Other
8.35k stars 1.29k forks source link

Diagram search should only commit navigation changes on `ENTER` #2189

Open nikku opened 1 month ago

nikku commented 1 month ago

Describe the Bug

I found one odd thing with diagram search: As I search for an element (on a different plane, or anywhere) I only want the viewport to be commited when I ENTER. Pressing ESC I want the old viewport to be restored.

Today the opposite thing happens: Search will always change the viewport, and requires me to navigate back (to the previous place) manually. A tedious process:

capture fBCvBm_optimized

Steps to Reproduce

  1. Open diagram
  2. Search for element
  3. See viewport changes
  4. ESC -> viewport does not reset to original version

Expected Behavior

Environment