search

bpmn-io / bpmn-js

A BPMN 2.0 rendering toolkit and web modeler.
https://bpmn.io/toolkit/bpmn-js/
Other
8.35k stars 1.29k forks source link

Bug: demo + modeler example: if editing text followed by saveXML, the new text is missing in the xml #2197

Open c-antin opened 1 week ago

c-antin commented 1 week ago

Describe the Bug

if editing text followed by saveXML, the new text is missing in the xml

Steps to Reproduce

  1. goto https://demo.bpmn.io/
  2. append a task
  3. double click to edit text
  4. add text
  5. click download xml button
  6. re-import xml
  7. observe missing text

Expected Behavior

editing text should trigger change event. Or is there a way to trigger change before saving xml? Note: every non-text action (e.g. click on elements) seems to trigger change.

Environment

philippfromme commented 3 days ago

Did you actually confirm the label editing though Enter or clicking outside of the element? If you don't do that before downloading the XML the label will be missing.

philippfromme commented 3 days ago

A screencast demonstrating your issue would be helpful.

c-antin commented 3 days ago

Did you actually confirm the label editing though Enter or clicking outside of the element? If you don't do that before downloading the XML the label will be missing.

I was of the impression that editing text without clicking outside would be enough to register the change. I guess it's more of an inconvenience than a bug, then?