search

bpmn-io / bpmn-js

A BPMN 2.0 rendering toolkit and web modeler.
https://bpmn.io/toolkit/bpmn-js/
Other
8.61k stars 1.33k forks source link

Global references are not kept when replacing an event (interrupting to non-interrupting) #2249

Open nikku opened 2 weeks ago

nikku commented 2 weeks ago

Describe the Bug

I replace an event (i.e. a boundary event) from interrupting to non-interrupting. I see that the global message reference gets lost.

We have existing test cases for the desired behavior (reference is kept), but due to nested it(..., function() { it(...); } calls these are not actually executed :see_no_evil:.

https://github.com/bpmn-io/bpmn-js/pull/2248 uncovered this miss-use, and the bug.

Steps to Reproduce

  1. Uncomment these tests
  2. See that test suite fails

Expected Behavior

When replacing an event (toggling interrupting / non-interrupting) we keep the global element reference.

Environment

Related to https://github.com/bpmn-io/bpmn-js/issues/1906

sombrek commented 2 weeks ago

Cf. #1906