bpmn-io / bpmn-moddle

Read and write BPMN 2.0 XML from JavaScript.
MIT License
444 stars 162 forks source link

New `bpmn-moddle` version is incompatible with the node v16 #113

Closed corocoto closed 7 months ago

corocoto commented 7 months ago

Describe the Bug

I tried to upgrade the bpmn-moddle package to it's latest version by using Node v16. After trying it, I got an error.

The main reason why it's happen is that bpmn-moddle using the latest moddle-xml package. And the latest version of moddle-xml only compatible with node' versions >= 18.

Steps to Reproduce

  1. Install Node.js v16
  2. Try to install bpmn-moddle
  3. Get an error linked on the node's version:
    error moddle-xml@11.0.0: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.14.2"
    error Found incompatible module.

Expected Behavior

It can have two resulted ways:

  1. bpmn-moddle will install correctly with node v16
  2. Upgrade bpmn-moddle's engines field. By setting ">= 18" (instead of current configuration with ">= 16"). To show that the latest bpmn-moddle package version is only compatible with node' versions >= 18

Environment

barmac commented 7 months ago

Thanks for sharing. Note that Node 16 is out of support, and the most recent supported version is 18: https://nodejs.org/en/about/previous-releases

I think it makes sense to update the engines field since we depend on Node 18>= only deps.