feat: support scoped rules

patoncrispy commented 4 years ago

Intended to support scoped packages as highlighted in Issue https://github.com/bpmn-io/bpmnlint/issues/35.

Closes #35

CLAassistant commented 4 years ago

All committers have signed the CLA.

nikku commented 4 years ago

For complete namespace support you'd need to update parseConfigName to support scoped packages, too.

nikku commented 4 years ago

Added failing integration test to your feature branch: https://github.com/bpmn-io/bpmnlint/pull/36/commits/2a6770a3c6dc3642f346ba03a02c04ed1357f928.

patoncrispy commented 4 years ago

Nice thanks @nikku will get on that now.

patoncrispy commented 4 years ago

Hey @nikku I keep getting errors running tests relating to install-local: Error: Command failed with exit code 1 (EPERM): install-local. That's all I have, unfortunately, but I'm not sure why I'm getting a permissions issue. The tests are failing in the before all hook of the cli-spec file.

nikku commented 4 years ago

Hey @nikku I keep getting errors running tests relating to install-local: Error: Command failed with exit code 1 (EPERM): install-local. That's all I have, unfortunately, but I'm not sure why I'm getting a permissions issue. The tests are failing in the before all hook of the cli-spec file.

Please paste the full trace here.

patoncrispy commented 4 years ago

@nikku it's pretty useless, but here is what I have:

  1) cli
       "before all" hook in "cli":
     Error: Command failed with exit code 1 (EPERM): install-local
      at makeError (node_modules/execa/lib/error.js:58:11)
      at handlePromise (node_modules/execa/index.js:112:26)
      at process._tickCallback (internal/process/next_tick.js:68:7)

patoncrispy commented 4 years ago

I extracted the stderr from execa and got the following:

Command failed: npm i --no-save "/var/folders/cg/vy26v0hd53j2dhxfsnstjw5w0000gn/T/node-local-install-sktwictuk1usuali/bpmnlint-6.2.0.tgz" "/var/folders/cg/vy26v0hd53j2dhxfsnstjw5w0000gn/T/node-local-install-sktwictuk1usuali/bpmnlint-plugin-test-0.0.0.tgz"
npm ERR! path /Users/me/code/bpmnlint/test/integration/cli/node_modules/bpmnlint
npm ERR! code EISGIT\nnpm ERR! git /Users/me/code/bpmnlint/test/integration/cli/node_modules/bpmnlint: Appears to be a git repo or submodule.
npm ERR! git     /Users/me/code/bpmnlint/test/integration/cli/node_modules/bpmnlint
npm ERR! git Refusing to remove it. Update manually,\nnpm ERR! git or move it out of the way first.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/me/.npm/_logs/2019-10-17T14_28_16_315Z-debug.log

    at ChildProcess.exithandler (child_process.js:294:12)
    at ChildProcess.emit (events.js:198:13)
    at maybeClose (internal/child_process.js:982:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
  killed: false,
  code: 1,
  signal: null,
  cmd:
   \'npm i --no-save "/var/folders/cg/vy26v0hd53j2dhxfsnstjw5w0000gn/T/node-local-install-sktwictuk1usuali/bpmnlint-6.2.0.tgz" "/var/folders/cg/vy26v0hd53j2dhxfsnstjw5w0000gn/T/node-local-install-sktwictuk1usuali/bpmnlint-plugin-test-0.0.0.tgz"\' }',

patoncrispy commented 4 years ago

OK I just cleared the repo and cloned it again and it's working fine.

patoncrispy commented 4 years ago

@nikku seems to pass those tests now - could you take a look?

patoncrispy commented 4 years ago

hey @nikku any chance you could take another look at this?

nikku commented 4 years ago

Giving it another :eyes: is on my TODO list. :+1:

nikku commented 4 years ago

@philippfromme Can be reviewed despite the CI failure. I'll ship a follow up PR to silence the Node@latest warning.

bpmn-io / bpmnlint

feat: support scoped rules #36