Closed barmac closed 3 years ago
The build failed on Node 15 even though I have not changed code.
Interesting that it is failing because of one single new line, cf. https://travis-ci.com/github/bpmn-io/bpmnlint/jobs/404323815#L550
actual
\n\n/home/travis/build/bpmn-io/bpmnlint/test/integration/cli/diagram-broken.bpmn\n error Parse error: failed to parse document as <bpmn:Definitions>\n\n✖ 1 problem (1 error, 0 warnings)\n\n
expect
\n\n/home/travis/build/bpmn-io/bpmnlint/test/integration/cli/diagram-broken.bpmn\n error Parse error: failed to parse document as <bpmn:Definitions>\n\n✖ 1 problem (1 error, 0 warnings)\n
See the additional newline at the end.
Long story short, we should fix our CI builds to not use latest Node as too many magic things can happen with pre-stable node versions (i.e. 11, 13, 15, ...).
Fixed this one via https://github.com/bpmn-io/bpmnlint/pull/45/commits/3eb1acf5bc5611b3fe334b8132705064da2033e2.
Thanks. How do you like the PR?
Generally, as this is a matter of style, we do not provide rationale for these rules, similar to how I thought eslint does it.
In some cases however, eslint provides strong rationale for why something should not be done, example: https://eslint.org/docs/rules/for-direction#rule-details
So I'd be fine adding an explaination here.
I think that as long as rules don't lead to confusion on forums/issues, it's OK to assume they are self-explanatory. In this case, however, there have been a GitHub issue and a forum post questioning rule's existence.
Related to #41 Closes #44
Definition of Done