Closed clementdessoude closed 3 years ago
Hi @nikku !
I added some test, and tried to modify the Travis configuration to add builds on mac and windows. I have to admit I do not understand why it didn't launch the Travis CI on my last commit, do you have an idea ?
I have to admit I do not understand why it didn't launch the Travis CI on my last commit, do you have an idea ?
Likely travis does not allow external contributors to fiddle around with the CI configuration.
Extracted the CI update to https://github.com/bpmn-io/bpmnlint/pull/48. Makes sure to have CI on all these environments before merging the globbing support.
Apparently we ran out of "credits" with our TravisCI account. Despite being on a paid plan, depite having paid extra for additional credits. We'll need to resolve this.
Thanks in advance already for your PR. We'll merge it, eventually :wink:.
Merged via https://github.com/bpmn-io/bpmnlint/commit/23c26a3ca6d41164c5febe108c8f5519b4f90f4f without the CI changes.
Ended up using tiny-glob rather than fast-glob for speed and size reasons.
Great news!
Which issue does this PR address?
I propose this PR to address the issue I raised about glob search.
It uses the fast-glob libray that can be found here: https://github.com/mrmlnc/fast-glob
It is the same library as Prettier for retrieving matching files: https://github.com/prettier/prettier/blob/86ad2997685a9ac86617502531e9d203976d23ea/src/cli/expand-patterns.js
Closes #46
Acceptance Criteria
N/A
Definition of Done