bpmn-io / bpmnlint

Validate BPMN diagrams based on configurable lint rules.
MIT License
121 stars 36 forks source link

feat: add optional name to tests through RuleTester.verify #68

Closed philippfromme closed 2 years ago

philippfromme commented 2 years ago

Improves console output from

rules/camunda-cloud-1-0-integration
    should lint valid
      √ test case #1
      √ test case #2
      √ test case #3

to

rules/camunda-cloud-1-0-integration
    should lint valid
      √ test case #1 bpmndi elements
      √ test case #2 parse collaborations
      √ test case #3 conditional sequence flows

Closes #67

philippfromme commented 2 years ago

You mean any test coverage at all for rule-tester.js? 🤡

philippfromme commented 2 years ago

Will add of course. 👍🏻

barmac commented 2 years ago

I can't see a single place where this is used. Can you add the names to existing tests in the PR too?

nikku commented 2 years ago

@philippfromme Any coverage = https://github.com/bpmn-io/bpmnlint/blob/master/test/rules/end-event-required.js#L1, for example.

philippfromme commented 2 years ago

I added names to some of the tests to verify it's working. 👍🏻