Doesn't check missing an end

bpmn-io / bpmnlint

Validate BPMN diagrams based on configurable lint rules.

MIT License

121 stars 36 forks source link

Doesn't check missing an end #88

Closed linlyn2022 closed 1 year ago

linlyn2022 commented 2 years ago

Describe the Bug

The codes don't seem to detect the issue with an activity that is missing an end event. I am attaching the bpmn file (in zip) for your convenience

Trial missing end.zip

Steps to Reproduce

remove the check activity from the diagram and check for errors. The system spots three errors
add an activity to the XOR gateway and name the activity issue
check errors again. Only three errors are identified

Expected Behavior

1. There should be an end event attached to the activity issue (which is incorrectly named by the way. I have submitted to you my request for a rule about naming conventions).

Environment

Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
OS: [e.g. Windows 7]
Library version: [e.g. 2.0.0]
I used Google Chrome which is in the incognito mode
The operating system of my laptop is Windows 10

nikku commented 2 years ago

Missing end events are valid BPMN. What rule (cf. rules) would you expect to catch this error? ~~If you identified the rule, please open a respective issue in bpmnlint.~~

linlyn2022 commented 2 years ago

The rule is end-event-required, but it may not work all the time. I already created an issue. Please check, Nico. Thanks!

nikku commented 2 years ago

My bad. Thanks for clarifying. Looking at our end-event-required documentation this indeed looks like a valid issue:

Explicitly modeling it improves the understandability of drawn process diagrams.

We should capture the same thing for process start I believe (could be a separate issue):

nikku commented 2 years ago

Moving this one into our backlog, thanks for reporting!

linlyn2022 commented 2 years ago

Thx! How long will it take to address the issue?

On Tue, Aug 23, 2022, 02:58 Nico Rehwaldt @.***> wrote:

Moving this one into our backlog, thanks for reporting!

— Reply to this email directly, view it on GitHub https://github.com/bpmn-io/bpmnlint/issues/88#issuecomment-1223634722, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2UT54STZR7LIWYN4MJERRTV2RZAHANCNFSM57HZ6YSA . You are receiving this because you authored the thread.Message ID: @.***>

nikku commented 2 years ago

We welcome contributions to address this issue.

nikku commented 1 year ago

Will be addressed via https://github.com/bpmn-io/bpmnlint/pull/103.