we're in the process of upgrading from our own typedefs to the official diagram-js ones and found some cases where arguments are theoretically optional but documented as required in the jsdoc.
This PR adjusts the cases we noticed our build complaining.
The changes are usually where the argument is consumed with a fallback value in the javascript code, e.g. argument || {}.
If you expect these arguments not to be optional in the generated types, I can also close the PR.
nikku
commented
6 months ago
Hi,
we're in the process of upgrading from our own typedefs to the official diagram-js ones and found some cases where arguments are theoretically optional but documented as required in the jsdoc.
This PR adjusts the cases we noticed our build complaining. The changes are usually where the argument is consumed with a fallback value in the javascript code, e.g.
argument || {}.If you expect these arguments not to be optional in the generated types, I can also close the PR.
Thanks