feat(context-pad): order entries by `groupOrder` and `order`

bpmn-io / diagram-js

A toolbox for displaying and modifying diagrams on the web.

MIT License

1.65k stars 418 forks source link

feat(context-pad): order entries by `groupOrder` and `order` #886

Closed philippfromme closed 2 months ago

philippfromme commented 2 months ago

Order entries by groupOrder first and by order second. Both are optional and default to 0. For groupOrder, the first entry of a group with a defined groupOrder will define the order of the group.

nikku commented 2 months ago

What would be the alternative to this? I see a couple of options:

Name groups alphabetically and apply a respective ordering
Do some post processing (lowest priority handler) to re-order things (groups and entries?)

I'm worried that especially the groupPriority is a fragile solution, especially when different entries in a single group have a different groupPriority.

Related: In other places of the code base we already use priority, namely in the popup menu. Does it work the same way?

philippfromme commented 2 months ago

After discussing this with @nikku and since we don't need it right now I'll close this pull request.