bpmn-io / diagram-js

A toolbox for displaying and modifying diagrams on the web.
MIT License
1.65k stars 418 forks source link

fix: assign correct role attribute in popup menu item #918

Closed barmac closed 3 weeks ago

barmac commented 3 weeks ago

Related https://github.com/camunda/camunda-modeler/issues/4383

Proposed Changes

This removes incorrect aria-role attribute from the popup menu item. Note that the <li> element has an implicit role of listitem and a role=button element as a direct child of a list is not allowed.

Checklist

To ensure you provided everything we need to look at your PR:

barmac commented 3 weeks ago

I removed the role attribute to keep the changes as minimal as possible. aria-role was already incorrect, so there are no changes in the a11y tree with this PR.