Do not query DOM for `Canvas#hasMarker` check - Githubissues

bpmn-io / diagram-js

A toolbox for displaying and modifying diagrams on the web.

MIT License

1.65k stars 418 forks source link

Do not query DOM for `Canvas#hasMarker` check #919

Closed nikku closed 2 weeks ago

nikku commented 2 weeks ago

Proposed Changes

As implemented by @marstamm and discussed in https://github.com/bpmn-io/diagram-js/pull/915#issuecomment-2183924816 we want marker querying to not be a DOM operation (costly).

Related to https://github.com/camunda/camunda-modeler/issues/4335

Checklist

To ensure you provided everything we need to look at your PR:

[x] Brief textual description of the changes present
[ ] Visual demo attached
[ ] Steps to try out present, i.e. using the @bpmn-io/sr tool
[x] Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}