Search fixes - Githubissues

bpmn-io / diagram-js

A toolbox for displaying and modifying diagrams on the web.

MIT License

1.71k stars 418 forks source link

Search fixes #929

Closed philippfromme closed 2 months ago

philippfromme commented 2 months ago

Proposed Changes

prevents resetting view when clicking outside of search (cf. https://github.com/bpmn-io/bpmn-js/pull/2187#issuecomment-2303198593)
reduces padding for scrolling into view

brave_rL206TWcO6

Checklist

To ensure you provided everything we need to look at your PR:

[x] Brief textual description of the changes present
[x] Visual demo attached
[x] Steps to try out present, i.e. using the @bpmn-io/sr tool
[x] Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

nikku commented 2 months ago

Try out via npx @bpmn-io/sr -l bpmn-io/diagram-js#search-fixes bpmn-io/bpmn-js.