I traced a bug that caused the preselect marker class not being removed from an element. In the process I found that the whole marker logic we introduced via https://github.com/bpmn-io/diagram-js/pull/913 is not necessary, after all: We use standard selection, and attach a djs-search-open marker to the diagram container; this is enough for us to handle "special selection" using plain CSS:
nikku
commented
2 weeks ago
Proposed Changes
I traced a bug that caused the
preselectmarker class not being removed from an element. In the process I found that the whole marker logic we introduced via https://github.com/bpmn-io/diagram-js/pull/913 is not necessary, after all: We use standard selection, and attach adjs-search-openmarker to the diagram container; this is enough for us to handle "special selection" using plain CSS:The change in action, testing against bpmn-js.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}