search

bpmn-io / diagram-js

A toolbox for displaying and modifying diagrams on the web.
MIT License
1.71k stars 418 forks source link

fix: limit overly permissive regex range #949

Closed barmac closed 1 week ago

barmac commented 2 weeks ago

Proposed Changes

This fragment of code deals with letters so it should not match additional characters.

Checklist

To ensure you provided everything we need to look at your PR:

barmac commented 2 weeks ago

I'll check if it's not breaking bpmn-js, but should be safe to merge.

barmac commented 1 week ago

Testing on bpmn-js via https://github.com/bpmn-io/bpmn-js/actions/runs/11815595868

barmac commented 1 week ago

I had to skip types test as they are apparently not generated for install from commit. This is the new run: https://github.com/bpmn-io/bpmn-js/actions/runs/11815660568

barmac commented 1 week ago

A manual smoke test did not reveal any issues.

barmac commented 1 week ago

I'll add a test case for this util.

barmac commented 1 week ago

Test cases added via https://github.com/bpmn-io/diagram-js/pull/949/commits/06db3c76c2c1729dd75b55cd3c0f80e29fbc787a