search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
296 stars 137 forks source link

Changed expression language indicator not shown #647

Open Egoplayer opened 3 years ago

Egoplayer commented 3 years ago

Describe the Bug

The DMN Editor doesn't show the set expression language for some dmn cells. If the expression language is changed from the default FEEL to any other expression language a blue indicator appears on the right side of the cell to show there is a changed expression language active. This does only work for every second cell.

dmn_script_indicators

Hover over the cells shows the extended indicated (shows the set expression language) anyway even if the blue indicator is not shown Steps to Reproduce

  1. Create a new DMN via the online modeler https://demo.bpmn.io/dmn
  2. Add 2-3 rules (rows)
  3. change the expression language for every input cell to another expression language (e.g. Javascript)

The Issue should occur in lines 2, 4, 6, ...

Expected Behavior

I expect to show this blue indicator in every cell if the expression language is changed

Environment

people-ware commented 3 years ago

I think this is caused by

.dmn-decision-table-container .cell .dms-badge.dmn-expression-language {
  z-index: -1;
}

in https://github.com/bpmn-io/dmn-js/blob/develop/packages/dmn-js-decision-table/assets/css/dmn-js-decision-table.css#L536

pinussilvestrus commented 3 years ago

Thanks for reporting! This relates to https://github.com/camunda/camunda-modeler/issues/1678

Feel free to open a PR that improves the situation!