search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
289 stars 137 forks source link

Implement variable suggestions #791

Closed barmac closed 11 months ago

barmac commented 11 months ago

https://github.com/bpmn-io/dmn-js/assets/28307541/aa4ec739-b576-4957-b54c-30d77d2265fa

Closes #785

marstamm commented 11 months ago

Works great, love the feature! Have you considered adding an integration test for the feature?

barmac commented 11 months ago

Works great, love the feature! Have you considered adding an integration test for the feature?

What would it test?

marstamm commented 11 months ago

I was thinking that we could check that variables are passed to the Editor component, if that is manageable. If not, feel free to merge anyway

barmac commented 11 months ago

@marstamm Check out https://github.com/bpmn-io/dmn-js/pull/791/commits/1b2efbf973b1c13c44800dbd0de43b833688610a

nikku commented 11 months ago

Amazing stuff! :tada:

nikku commented 11 months ago

Let's ship it :boat: