search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
295 stars 137 forks source link

Drop transpilation #814

Open nikku opened 10 months ago

nikku commented 10 months ago

What should we do?

Given that we lifted our language level to ES2018 we can now drop our transpilation of classes.

Why should we do it?

Ensure that our bundles are as small as possible.

barmac commented 10 months ago

We could probably drop transpilation for dmn-js-drd, but for Inferno-based libraries we still need to somehow handle JSX.

AFAIK we don't transpile classes since the migration, e.g. https://unpkg.com/browse/dmn-js-decision-table@15.0.0/lib/Editor.js

nikku commented 10 months ago

I'd love us to transpile only what is absolutely necessary. Right now we transpile many things, and we cannot use @babel/preset-env to define a clear target (ES2018).

barmac commented 10 months ago

Ideally, I'd use babel only to support the latest browsers. This is what we declared anyway. ES2018 was set as a target to prevent transpilation, but in dmn-js we can't work without it at the moment due to Inferno.