bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
289 stars 137 forks source link

Implement BKM as literal expression #826

Closed barmac closed 4 months ago

barmac commented 7 months ago

What should we do?

Why should we do it?

Part of https://github.com/camunda/product-hub/issues/1858

Related to https://github.com/bpmn-io/dmn-js/issues/704

barmac commented 7 months ago

@lmbateman We will need to discuss how we want the user to specify the parameters.

barmac commented 6 months ago

Today, @nikku and I talked about this topic.

We concluded that it makes sense to have a new project within dmn-js family dedicated for all boxed expressions with nesting in mind. Initially, this will support BKM as literal expression. In the future, we can implement other boxed expressions as well as migrate the existing ones (decision table, literal expression for decision).

There's also an idea to upgrade the rendering engine to migrate off Inferno 5, but it's a separate story which can be implemented after the BKM as literal expression is done.

barmac commented 6 months ago

Current state of this is available at https://boxed-expression.netlify.app/

There's still much to do regarding style, but at least the core features work.

barmac commented 5 months ago

@lmbateman and I discussed today the UI part and agreed on the following:

  1. The formal parameters will be displayed more like in the specification first, and open the modeling view once edit button is clicked ("pencil").
  2. The expression will be displayed without box.