search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
288 stars 137 forks source link

FEEL editor does not properly handle multi-line cells #838

Closed nikku closed 2 months ago

nikku commented 4 months ago

Describe the Bug

When I have a decision table with multiple lines in a cell, then the FEEL editor looks super odd:

capture z0PTeB_optimized

Steps to Reproduce

Steps to reproduce the behavior:

  1. open test diagram
  2. see above broken behavior

Expected Behavior

Editor fits to cell, and overflows if space is not enough. We employ automatic line wrapping (to fit contents) to mimic textarea behavior.

Environment

Please complete the following information:

barmac commented 4 months ago

I can reproduce this.

nikku commented 3 months ago

@barmac Did we by any chance address this issue? I cannot reproduce anymore integrating the latest dmn-js version into our demo:

capture W8pbAC_optimized

nikku commented 3 months ago

Never mind, this is still an issue for overflowing content:

image

nikku commented 2 months ago

Should be an easy fix (adapt properties panel behavior), cf. https://github.com/bpmn-io/properties-panel/blob/1b2cbec8e55bfb470695bde2a302e60110a65261/src/components/entries/FEEL/FeelEditor.js#L103.

barmac commented 2 months ago

Thanks for the insight. This will be useful for a person who fixes this.

nikku commented 2 months ago

I'll have a look if it is this easy :heavy_check_mark: