search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
288 stars 137 forks source link

Fix issues found with axe #843

Closed barmac closed 4 months ago

barmac commented 4 months ago

Related to https://github.com/camunda/product-hub/issues/2189

Closes #821

barmac commented 4 months ago

I will push more changes to this PR so that we can merge it more easily. Otherwise I'd have to open PRs based on this branch.

barmac commented 4 months ago

The way to verify the fixes that I suggest is via axe dev tools extension for chrome.

marstamm commented 4 months ago

I found 1 more issue with the axe dev tool. The Expression language dropdown does not have a label. I am not sure if this is relevant at all, as we do not have this field in C8. image

Otherwise, looks very clean! Great work 👏

barmac commented 4 months ago

fix: ensure accessible names for expression language select

Done via https://github.com/bpmn-io/dmn-js/pull/843/commits/af13b8dcef9642bcdd00c38ee800a762363e184b