search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
288 stars 137 forks source link

feat(label-editing): hide labels while editing #851

Closed marstamm closed 3 months ago

marstamm commented 3 months ago

related to https://github.com/bpmn-io/diagram-js-direct-editing/issues/23

This PR ensures we hide the labels on the diagram when direct editing is active. This aligns the behavior with bpmn-js and enables us to remove the white background in https://github.com/bpmn-io/diagram-js-direct-editing/issues/23

nikku commented 3 months ago

@marstamm Could you attach a screen capture of the proposed behavior?

marstamm commented 3 months ago

For now, nothing will change as the labels are currently "hidden" by the white background of direct editing. With https://github.com/bpmn-io/diagram-js-direct-editing/pull/39 , we will not hide drilldown/non-square shapes by the white background:

Recording 2024-04-18 at 14 24 05

Without this change, the original label would still be visible while editing: Recording 2024-04-18 at 14 25 29