search

bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
288 stars 137 forks source link

Commit on change event and let browser handle undo of text inputs #864

Closed barmac closed 2 months ago

barmac commented 2 months ago

Closes #859

barmac commented 2 months ago

@philippfromme Do you need any support with reviewing this?

philippfromme commented 2 months ago

@barmac Just so I understand correctly: We're trying to make inputs behave like direct-editing, where a command is issued only once I close/blur the editor?

brave_iB0l6evExR

This is not the case for other inputs yet and we're okay with that?

brave_4CXDVueQZC

barmac commented 2 months ago

Yes, that's the point of the PR. Right now I want to fix it in the boxed expression where I experienced the most annoying issues.