bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
288 stars 137 forks source link

feat: add edit input/output button #883

Closed barmac closed 1 month ago

barmac commented 1 month ago

Proposed Changes

Run npx @bpmn-io/sr bpmn-io/dmn-js#845-edit-button-for-decision-table-head to try this out locally.

The button is visually hidden unless focussed with keyboard.

Closes #845

https://github.com/bpmn-io/dmn-js/assets/28307541/87b0de58-5779-40a1-b436-09158ea2ff25

Checklist

To ensure you provided everything we need to look at your PR:

nikku commented 1 month ago

@barmac Did we break the + button outline in the process?

nikku commented 1 month ago

The button is visually hidden unless focussed with keyboard.

Really good stuff :clap: :heart:

barmac commented 1 month ago

@barmac Did we break the + button outline in the process?

No, the additional outline is coming from VoiceOver.

barmac commented 1 month ago

So this is how it looks like without VO:

image