Closed barmac closed 1 month ago
@barmac Did we break the +
button outline in the process?
The button is visually hidden unless focussed with keyboard.
Really good stuff :clap: :heart:
@barmac Did we break the
+
button outline in the process?
No, the additional outline is coming from VoiceOver.
So this is how it looks like without VO:
Proposed Changes
Run
npx @bpmn-io/sr bpmn-io/dmn-js#845-edit-button-for-decision-table-head
to try this out locally.The button is visually hidden unless focussed with keyboard.
Closes #845
https://github.com/bpmn-io/dmn-js/assets/28307541/87b0de58-5779-40a1-b436-09158ea2ff25
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}