bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
288 stars 137 forks source link

Long name overlaps the drill down icon #884

Open barmac opened 1 month ago

barmac commented 1 month ago

Describe the Bug

image

Steps to Reproduce

Write a long name on a decision with decision table.

Expected Behavior

No overlap.

Environment

Please complete the following information:


Reported via https://camunda.slack.com/archives/C0693F1NFK5/p1718869256259379

jarekdanielak commented 6 days ago

@lmbateman what would be the preferred UI behavior when this happens?

lmbateman commented 6 days ago

Thanks for asking! This appears to be an issue with the BPMN editor as well (and is worse in a way, because the task elements are less wide). Web:

image

Desktop:

image

The preferred UI behavior is no overlap. In the example Maciej gave, we could move the text down a bit, or give it more of a left margin. In the absence of other data, I have a slight preference for the left margin, but any solution should be consistent with the BPMN editor, so I'd want to do more research before making a strong recommendation. However, at some point any solution we provide is going to break if the name is long enough, since I don't think we want to enforce a character limit.