bpmn-io / dmn-js

View and edit DMN diagrams in the browser.
https://bpmn.io/toolkit/dmn-js/
Other
295 stars 137 forks source link

Port implicit keyboard binding over to decision editors #920

Open nikku opened 2 hours ago

nikku commented 2 hours ago

Is your feature request related to a problem? Please describe.

With https://github.com/bpmn-io/diagram-js/pull/662 we made sure that keyboard binding works with browser focus, implicitly, and well integrated into the users UX flow. This is not fully integrated in our DMN editors yet, with explicit bind stubs remaining.

Describe the solution you'd like

Describe alternatives you've considered

None.

Additional context

Child of https://github.com/bpmn-io/internal-docs/issues/1081

nikku commented 2 hours ago

(We could also consider it a bug that this is not properly integrated (yet), hence any follow-up improvement in the same style is not a user land break anymore).

barmac commented 1 hour ago

Since the change was already announced, indeed this looks like an incomplete implementation hence bug.