bpmn-io / extract-process-variables

An util for bpmn-js to extract Camunda BPM process variables from a BPMN 2.0 diagram.
MIT License
0 stars 2 forks source link

Event Definition Variables Support #10

Closed pinussilvestrus closed 3 years ago

pinussilvestrus commented 3 years ago

Which issue does this PR address?

Closes #9

Acceptance Criteria

Definition of Done

MaxTru commented 3 years ago

Not blocking this PR, but we should toggle it as part of https://github.com/camunda/camunda-modeler/issues/2070: you can define twice the same variable in a single event: Screenshot_20210120_130825 Screenshot_20210120_130838

nikku commented 3 years ago

Not blocking this PR, but we should toggle it as part of camunda/camunda-modeler#2070: you can define twice the same variable in a single event.

Not a feature request in this library, right?

MaxTru commented 3 years ago

Oops, I was too late. I think the empty string "issue" is worth a thought.

pinussilvestrus commented 3 years ago

No problem. Let's discuss the open issues and I'll follow up with a second PR.

nikku commented 3 years ago

My bad, was too quick with my fingers. @pinussilvestrus I guess Max thoughts are worth another look?