search

bpmn-io / extract-process-variables

An util for bpmn-js to extract Camunda BPM process variables from a BPMN 2.0 diagram.
MIT License
0 stars 2 forks source link

Get rid of unused _?_ peer dependency #17

Closed nikku closed 2 years ago

nikku commented 2 years ago

What should we do?

camunda-bpmn-moddle is unused as it looks like. Get rid of it as a peer dependency.

Why should we do it?

Don't depend on stuff that we do not need.

pinussilvestrus commented 2 years ago

Without camunda-bpmn-moddle, it would not be possible to retrieve the needed props, as form fields. What we could argue is that it's not a peer dependency of this library, but of the bpmn-js-properties-panel implementation.

nikku commented 2 years ago

Yes, exactly.

You'd need to verify against the run-time schema if the extension is loaded. Having it as a peer dependency does, unfortunately, nothing.

pinussilvestrus commented 2 years ago

You are right 👍 I quickly followed up on this one: https://github.com/bpmn-io/extract-process-variables/pull/18