bpmn-io / form-js

View and visually edit JSON-based forms.
https://bpmn.io/toolkit/form-js/
Other
405 stars 103 forks source link

RTL direction support via properties panel (part 1) #1212

Closed okaeiz closed 3 months ago

okaeiz commented 3 months ago

Has worked on #1205

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: okaeiz
:x: root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

okaeiz commented 3 months ago

I made some changes before configuring my Git user; can we skip the CLA signature for root?

Skaiir commented 3 months ago

@okaeiz We can, but major thing right now is to clean up the PR, I'll review the code afterwards.

You might want to reset to bpmn-io:develop, and then cherry pick your changes into it. I see some duplicate commits, and also a tons of merge commits which we don't allow in PRs.

Skaiir commented 3 months ago

If the PR isn't yet in a finished state, we usually make use of the draft functionality of github :)