bpmn-io / form-js

View and visually edit JSON-based forms.
https://bpmn.io/toolkit/form-js/
Other
415 stars 106 forks source link

Implement scalable component library #503

Closed pinussilvestrus closed 1 year ago

pinussilvestrus commented 1 year ago

What should we do?

image

Why should we do it?

We want to help form designers build forms in less time by providing component library that allows to easily discover, browse, and use form components, as well as to understand what these components are used for.

Related to https://github.com/camunda/product-hub/issues/728

pinussilvestrus commented 1 year ago

(small) Kickoff is scheduled for Thursday (19th Jan).

pinussilvestrus commented 1 year ago

Kickoff results - 19th January

Link to the board: https://miro.com/app/board/uXjVPx8pfPU=/

Decisions

Action items

pinussilvestrus commented 1 year ago

Early feedback

I created a first demo of the updated palette integrated in form-playground. I did not include any breakpoints, yet. I also updated the titles to not use uppercase and match the design as proposed by @RomanKostka (cf. https://github.com/camunda/product-hub/issues/728#issuecomment-1396579623).

https://49-updated-palette--camunda-form-playground.netlify.app/

Feel free to have an early look and give feedback 👍

image

pinussilvestrus commented 1 year ago

One thing I search for feedback on, in particular, is the drag interaction of the field options. I left the hover effect, which feels like a button, which is misleading, especially as long we do not support click-to-create in forms.

image

Adding a cursor would be something, but we do not use different cursors in other places so far.

pinussilvestrus commented 1 year ago

Feedback from @christian-konrad via Slack

Some notes:

  • The search input looks different from the inputs in the properties panel (e.g. border color is darker)
  • The search icon is not vertically centered and potentially too dark/flashy
  • No empty state yet
  • A clear button on the search field would be cool
  • The dark hover animation feels odd. What about a “float” animation (shadow/zoom?)
  • With this size, we limit component names to 10 chars (don’t know if that will be an issue)
  • The chevrons are not vertically centered anymore
pinussilvestrus commented 1 year ago

Found another quirk: The panel header is not sticky anymore.

pinussilvestrus commented 1 year ago

[fyi] I played a bit with keyboard support for the new component library. Although I like the look&feel already a lot, I believe we need to invest in the overall editor keyboard story (cf. https://github.com/bpmn-io/form-js/issues/173), so everything plays nicely together. Only fixing it for the sidebar won't do the trick.

Kapture 2023-01-20 at 11 47 33