search

bpmn-io / properties-panel

Library for creating bpmn-io properties panels.
MIT License
31 stars 21 forks source link

fix: move popout close button to header #368

Closed Skaiir closed 5 months ago

Skaiir commented 5 months ago

Closes #364

nikku commented 5 months ago

@Skaiir Please share a preview (capture) of the proposed interaction. This allows others to quickly see what is intended here.

Alternatively a command that we can execute to reproduce this would do, too, i.e.

npx @bpmn-io/sr -l bpmn-io/properties-panel#364-move-popout-editor-close-button bpmn-io/bpmn-js-properties-panel
Skaiir commented 5 months ago

So the preview of what was proposed is the following, available in the issue referenced.

image

The tooltip is not included in this change as we currently do not make use of these in the editor. Might be interesting to take on later.

Also I was not aware of this SR tool, definitely worth highlighting it more because I've been copying my dependencies into form-js for years now :trollface:

nikku commented 5 months ago

We use the sr tool and want folks to add screenshots / captures to every PR so reviewers can quicker and easier relate to a given change and/or try it out. We'll ask for it again, in the future.

nikku commented 5 months ago

@Skaiir You go ahead and release these changes?

Skaiir commented 5 months ago

@nikku Will do after lunch time :)

nikku commented 5 months ago

Released with v3.20.1