bpmn-io / properties-panel

Library for creating bpmn-io properties panels.
MIT License
29 stars 20 forks source link

Refactor `ListGroup` open close handling #369

Closed nikku closed 3 months ago

nikku commented 3 months ago

Proposed Changes

This PR puts list group, on stable foundations, without magic :tm: :registered:

Checklist

To ensure you provided everything we need to look at your PR:


Related to https://github.com/camunda/camunda-modeler/issues/4382

barmac commented 3 months ago

There's one thing which I don't get. After I link it, the placeholder tests in the bpmn-js-element-templates start to fail:

Chrome Headless 121.0.6167.85 (Mac OS 10.15.7) provider/cloud-element-templates - CustomProperties placeholder should display placeholder (FEEL, String) FAILED
    AssertionError: expected '' to deeply equal 'Placeholder'
        at Context.eval (webpack-internal:///./test/spec/cloud-element-templates/properties/CustomProperties.spec.js:1662:36)
Chrome Headless 121.0.6167.85 (Mac OS 10.15.7) provider/cloud-element-templates - CustomProperties placeholder should display placeholder (FEEL, Text) FAILED
    AssertionError: expected '' to deeply equal 'Placeholder'
        at Context.eval (webpack-internal:///./test/spec/cloud-element-templates/properties/CustomProperties.spec.js:1673:36)

It looks unrelated though.

barmac commented 3 months ago

This was due to an outdated @bpmn-io/feel-editor on my machine. This is good now.