localError should take precedence over globalError

bpmn-io / properties-panel

Library for creating bpmn-io properties panels.

MIT License

31 stars 21 forks source link

localError should take precedence over globalError #370

Closed rcnicky closed 4 months ago

rcnicky commented 4 months ago

Describe the Bug

localError should take precedence over globalError, I use the custom translate module can not change the i18n language

Expected Behavior

localError should take precedence over globalError, should show chinese error label

https://github.com/bpmn-io/properties-panel/blob/c34fba48f145714a5f5729b60a22ed26aa6dbe3e/src/components/entries/TextField.js#L138

Environment

Host (Browser/Node version): Edge 18, Chrome 69
OS: Windows11
Library version: 3.21.0

barmac commented 4 months ago

Hi,

From the issue, I don't understand why we should implement your suggestion. The global error (better called "external error") precedence is required to support errors provided in https://github.com/camunda/linting/. In that case, we find it more relevant for the user that some property is not supported at all than that the value of the unsupported property would not have been valid if it had been supported.

If there's some problem in the translation labels that prevents i18n, please share it in another issue.