bpmn-io / vs-code-bpmn-io

View and edit BPMN diagrams in VSCode. Powered by bpmn.io tools.
https://marketplace.visualstudio.com/items?itemName=bpmn-io.vs-code-bpmn-io
MIT License
116 stars 38 forks source link

fix: document tracking issue when path of document changed #178

Closed huddeldaddel closed 1 week ago

huddeldaddel commented 2 weeks ago

Proposed Changes

This change removes the tracking of documents being renamed via document.onDidRename. It seems that is actually not required (anymore) since the previous document gets removed and then added again. I check that for all use cases I could identify:

Closes #176

Checklist

To ensure you provided everything we need to look at your PR:

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

huddeldaddel commented 2 weeks ago

So far I was not able to come up with a unit test that can save a document. Saving the current document to a new destination would be part of the required user interaction to test for this change. The available commands (that I found) do not accept a URL destination - instead they require user interaction via file dialog.

barmac commented 2 weeks ago

Thanks for the PR. Perhaps if the change cannot be tested via API, we will manually confirm the fix.

barmac commented 2 weeks ago

In the meantime, please adjust the commit message to adhere to conventional commits: https://www.conventionalcommits.org/ We use that for semantic releases.

barmac commented 1 week ago

I noticed you updated the PR title but not the commit message. I will do that in the merge.

image