Closed huddeldaddel closed 1 week ago
So far I was not able to come up with a unit test that can save a document. Saving the current document to a new destination would be part of the required user interaction to test for this change. The available commands (that I found) do not accept a URL destination - instead they require user interaction via file dialog.
Thanks for the PR. Perhaps if the change cannot be tested via API, we will manually confirm the fix.
In the meantime, please adjust the commit message to adhere to conventional commits: https://www.conventionalcommits.org/ We use that for semantic releases.
I noticed you updated the PR title but not the commit message. I will do that in the merge.
Proposed Changes
This change removes the tracking of documents being renamed via
document.onDidRename
. It seems that is actually not required (anymore) since the previous document gets removed and then added again. I check that for all use cases I could identify:Closes #176
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}