search

bpmn-io / vs-code-bpmn-io

View and edit BPMN diagrams in VSCode. Powered by bpmn.io tools.
https://marketplace.visualstudio.com/items?itemName=bpmn-io.vs-code-bpmn-io
MIT License
112 stars 37 forks source link

Add Properties Panel #20

Open pinussilvestrus opened 4 years ago

pinussilvestrus commented 4 years ago

Depends on #2

Add the bpmn-js-properties-panel to the Modeler Panel.

mschulte commented 3 years ago

Property-panel pretty much is needed to really make use of that plugin for devs isn't it?

pinussilvestrus commented 3 years ago

When you want to use this plugin in an implementation context, yes, the properties panel would be very useful. Integrating it into the BPMN Modeler is not a big deal, since it's just another extension.

What we have to find out first: Which Engine Context does the Properties Panel have (Zeebe vs. Camunda vs. only BPMN)? Can this be configured? How?

Depending on the context, another properties provider will be loaded and other properties will be displayed.

varnem2 commented 3 years ago

Could this just be left open ended for now until a better solution is found? Maybe just be able to view/edit the XML related to that element node. Sorry, I'm not super familiar with the codebase yet.

For example, a non interrupting timer at the very least you can manually read the xml or be pointed to the xml with the implementation. In our example we can at the very least see what the implementation of the timer is, no matter the implementing process engine. Maybe just a peek view at the element's xml? Just throwing out some ideas here.

pinussilvestrus commented 3 years ago

I could also imagine we introduce the Properties panel with general Engine agnostic support. Currently, the extension has no context in this regard. It just a basic BPMN Modeler.

Once we have camunda-bpmn-js stable, we could simply use this one and make the engine configurable in the VS Code settings.json.

ifedavid commented 3 months ago

Hey, is there still a plan for this or has this been released?

I also see that a separate properties panel repo has been created - https://github.com/bpmn-io/bpmn-js-properties-panel

Would that be integrated here? Thanks

barmac commented 3 months ago

Hi,

This issue is in the backlog which means that it's not the immediate priority of our team, but we want to look into this some day, maybe. We are also happy to accept external contributions.

Since camunda-bpmn-js is a thing for some time, one could consider using that project instead of plain bpmn-js in this plugin, and add a setting in vscode to decide what kind of properties panel to show: https://github.com/bpmn-io/vs-code-bpmn-io/issues/20#issuecomment-775825685

On the other hand, we may want to display a properties panel which fits the diagram as it is done in the Desktop Modeler: https://github.com/camunda/camunda-modeler/